Skip to content

Value tooltip when clicked#84

Merged
Hermanya merged 4 commits into
chart-kit:masterfrom
leommh-zz:master
Mar 7, 2019
Merged

Value tooltip when clicked#84
Hermanya merged 4 commits into
chart-kit:masterfrom
leommh-zz:master

Conversation

@leommh-zz

Copy link
Copy Markdown
Contributor

Description:

Which is?
It is a tooltip that opens when clicked on some chart value. It then displays this value to the user.

Why is it important?
I believe that in some cases it is possible that the user has many values ​​in the graph and at this moment wants to know the exact value of each dot.

Does the component work and is it perfect?
The component is working properly as it should, however I believe you can improve it, especially in its design.

Description:

Which is?
It is a tooltip that opens when clicked on some chart value. It then displays this value to the user.

Why is it important?
I believe that in some cases it is possible that the user has many values ​​in the graph and at this moment wants to know the exact value of each dot.

Does the component work and is it perfect?
The component is working properly as it should, however I believe you can improve it, especially in its design.
@Hermanya

Hermanya commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Thanks, I'll take a look over the next few days.

@Hermanya

Hermanya commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

I did a bit of refactoring: I moved the flashcards out into the example App, so that the library is more flexible.
Great work @leoMMH 👍
Thank you for the PR

@Hermanya Hermanya merged commit 38d8d47 into chart-kit:master Mar 7, 2019
@Hermanya

Copy link
Copy Markdown
Contributor

available in v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants